Skip to content

Publish exact versions #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 11, 2017
Merged

Publish exact versions #310

merged 7 commits into from
Aug 11, 2017

Conversation

@shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Aug 9, 2017 •
edited
Loading

  1. Manually remove the ^ from all modules' package.json
  2. Add the --exact flag to lerna publish in the script/release-pr (which we can test when this PR builds)
  3. Add --exact to the lerna publish call in the bump npm script

@shawnbot shawnbot requested a review from jonrohan August 9, 2017 22:18
@shawnbot shawnbot changed the title Publish exact versions [WIP] Publish exact versions Aug 9, 2017
@shawnbot shawnbot removed the request for review from jonrohan August 9, 2017 22:30
@shawnbot shawnbot changed the title [WIP] Publish exact versions Publish exact versions Aug 9, 2017
@shawnbot shawnbot requested a review from jonrohan August 9, 2017 22:51
@shawnbot
Copy link
Contributor Author

shawnbot commented Aug 9, 2017

@jonrohan I tested this by temporarily merging in #309 and getting a canary release published. Unlike before, I was able to then just npm install --save 9.3.0-alpha.4607fa12 in the styleguide and get the exact versions of all of the submodules.

jonrohan
jonrohan approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad

@broccolini broccolini merged commit 5880b56 into dev Aug 11, 2017
@broccolini broccolini deleted the exact-versions branch August 11, 2017 16:24
@broccolini broccolini mentioned this pull request Aug 11, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

+1 more reviewer

@broccolini broccolini broccolini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shawnbot @jonrohan @broccolini